enComputerevilvte
adm Find login register

bug: MATCH_STRING_EXEC prevents text selection

aragon
joined: 2010-04-13
posted: 5
promoted:
bookmarked:
1subject: bug: MATCH_STRING_EXEC prevents text selectionPromote 0 Bookmark 02010-04-18quote  

Hi,

I noticed a bug with the new MATCH_STRING_EXEC option.  When enabled it makes it impossible to select text with the mouse.  Not sure how to fix it.

 

Regards,

Aragon

caleb
joined: 2007-09-22
posted: 630
promoted: 134
bookmarked: 90
2subject: bug: MATCH_STRING_EXEC prevents text selectionPromote 0 Bookmark 02010-04-19quote  

It is the feature of libvte.

There is no convenient way to fix it.

Maybe you can #define MENU_MATCH_STRING_EXEC and right-click to choose "Copy" the matched string. :-)

aragon
joined: 2010-04-13
posted: 5
promoted:
bookmarked:
3subject: Promote 0 Bookmark 02010-04-21quote  

Hey.  I believe I have the fix for this.  I've also fixed another bug I discovered.  First the other bug:

URIs with "&" in them get cut off just before the "&".  Modified the system() string to enclose the URI in single quotes and it works.  Patch attached.

For the original bug, looks like the return of menu_popup() just needs to be tweaked.  If VTE reports no matched URI on a button press, return FALSE (instead of TRUE).  You'll see this in my patch.

My patch also changes the URI click button to 2 (middle click).  This is a better idea IMHO, and it's how at least one other VTE based term does things.

Hope you like. :)

enComputerevilvte
adm Find login register
views:5846