enComputerevilvte
adm Find login register

evilvte 0.4.5~pre4 released

caleb
joined: 2007-09-22
posted: 630
promoted: 134
bookmarked: 90
1subject: evilvte 0.4.5~pre4 releasedPromote 1 Bookmark 02009-06-12quote  

Changelog:
0.4.5~pre4
 * New option DEFAULT_TERMINAL_SIZE, remove DEFAULT_COLUMNS and DEFAULT_ROWS
 * New option SCROLLBAR, remove SCROLLBAR_LEFT and SCROLLBAR_RIGHT
 * Remove FONT_SIZE
   You may define font size in FONT option.

0.4.5~pre3
 * Improve command line option support
 * Improve hotkey customization a bit
   Please note that almost all CTRL_* in src/config.h are renamed to HOTKEY_*.
 * Limit font size range. Only 1 to 99 are accepted.
 * Remove VTE_DISABLE_DEPRECATED

0.4.5~pre2
 * Support virtual keyboard with libXtst
   You may disable libXtst by "./configure --disable-xtst".
   You may define VIRTUAL_KEYBOARD_MENU_KEY and VIRTUAL_KEYBOARD_WINDOW_KEY
 * Detect GTK+ version and disable unsupported options automatically.
 * Fix a displaying bug about toggling scrollbar or status bar.
 * Avoid an GTK+ autohide bug when CLOSE_DIALOG is enabled.
 * Avoid an GTK+ warning message when TAB_LABEL is customized.
 * Update license to latest format published by the Free Software Foundation.

0.4.5~pre1
 * Detect VTE version and disable unsupported options automatically.
 * Support VTE_DISABLE_DEPRECATED
   You may use deprecated VTE functions that were disabled in evilvte 0.4.4.
 * Support environment variable EVILVTE=min to build a minimal usable terminal.
 * Disable deprecated GLib, GDK and GTK+ functions.

0.4.4.1
 * Support command line -T option to assign program title.
   You may use -title as before.

The only one change between 0.4.4 and 0.4.4.1 is the command line -T option.

guest
2subject: Promote 0 Bookmark 02009-06-22quote  

Hi.

Thank you for evilvte, it's a very good and pretty fast terminal emulator, I've mode to it from Konsole.

Writing this because I've found a bug in it.

Config: tabs, close dialog, close safely.

The problem: while > 1 tab is opened clicking close and cancel in dialog main window disappears.

Solution:

delete_event must return gboolean, TRUE - do not destroy the window, FALSE - do destroy.

 P.S. Configuration dialog & rc file would be very nice ;)

guest
3subject: Promote 0 Bookmark 02009-06-22quote  

also there is a problem with build:

./configure creates ./src/config.o which is included by Makefile, but make clean, which should remove only build results removes it too, so

next make && make install goes  to /usr/local instead of prefix given by user.

caleb
joined: 2007-09-22
posted: 630
promoted: 134
bookmarked: 90
4subject: Promote 0 Bookmark 02009-06-23quote  

guest
The problem: while > 1 tab is opened clicking close and cancel in dialog main window disappears.

I think it is fixed on 0.4.5~pre2 and later ones. :-)

guest
./configure creates ./src/config.o which is included by Makefile, but make clean, which should remove only build results removes it too, so next make && make install goes  to /usr/local instead of prefix given by user.

Thank you. I will fix it in next release.

guest
P.S. Configuration dialog & rc file would be very nice ;)

I have no plan to support conffile soon. :-P
guest
5subject: Promote 0 Bookmark 02009-06-23quote  

caleb

I think it is fixed on 0.4.5~pre2 and later ones. :-)

 

I'm afraid it's not. I've been playing with 0.4.5~pre4 and here is the code:

src/sakura.c:1091 declaration is  void delete_event();

caleb
joined: 2007-09-22
posted: 630
promoted: 134
bookmarked: 90
6subject: Promote 0 Bookmark 02009-06-23quote  
guest
I'm afraid it's not. I've been playing with 0.4.5~pre4 and here is the code:

src/sakura.c:1091 declaration is  void delete_event();

Yeh, I know. I resolved that problem by another work around.

Do you still have the window-disappearing problem with 0.4.5~pre4?

guest
7subject: Promote 0 Bookmark 02009-06-23quote  

had. I've hacked sources so this problem is gone.

caleb
joined: 2007-09-22
posted: 630
promoted: 134
bookmarked: 90
8subject: Promote 0 Bookmark 02009-06-24quote  

guest
Config: tabs, close dialog, close safely.

The problem: while > 1 tab is opened clicking close and cancel in dialog main window disappears.

guest
had. I've hacked sources so this problem is gone.

I can not reproduce the bug on 0.4.5~pre4. :-(

When I found the bug, I noticed that it only occur on 32 bit environment.

I wrote CLOSE_DIALOG option under 64 bit environment, and it never encountered problems.

My daily use evilvte does not enable CLOSE_DIALOG, so I did not notice the problem until 0.4.5~pre2.

Timeline:

I started evilvte project under 64 bit environment -> support CLOSE_DIALOG -> ...(a long duration here)... -> I changed my daily use system to 32 bit environment -> ...(a long duration here)... -> I noticed the window-disappearing problem, which only occur on 32 bit environment -> I fixed it with a simple work around, and released 0.4.5~pre2.

Could you paste your patches here?

Or, could you provide the detailed procedure to reproduce the bug?

guest
9subject: Promote 0 Bookmark 02009-06-26quote  

the whole patch for evilvte:

diff --git a/src/sakura.c b/src/sakura.c
index d5afa87..2e54667 100644
--- a/src/sakura.c
+++ b/src/sakura.c
@@ -37,6 +37,7 @@
 #define BOTTOM 3
 
 #define CTRL event->keyval ==
+#define WITH_ALT(x) (event->state & GDK_MOD1_MASK) && (x)
 
 #if !EVILVTE_MINIMUM && !EVILVTE_MAXIMUM
 #include "config.h"
@@ -1088,7 +1089,7 @@ void change_statusbar_encoding();
 void add_tab();
 void button_clicked(GtkWidget *widget, void *data);
 void del_tab(GtkWidget *widget, int do_close_dialog);
-void delete_event();
+gboolean delete_event();
 void do_always_on_top();
 void do_change_saturation();
 void do_clear();
@@ -1866,7 +1867,7 @@ void change_statusbar_encoding()
 }
 #endif
 
-void delete_event()
+gboolean delete_event()
 {
 #if CLOSE_DIALOG && TAB
   if (gtk_notebook_get_n_pages(GTK_NOTEBOOK(notebook)) > 1) {
@@ -1902,7 +1903,7 @@ void delete_event()
 #if DO_TOGGLE_SCROLLBAR || DO_TOGGLE_STATUS_BAR
       recover_window_status();
 #endif
-      return;
+      return TRUE;
     }
   }
 #endif
@@ -1916,6 +1917,7 @@ void delete_event()
 #if !TAB
   del_tab(NULL, DO_CLOSE_DIALOG);
 #endif
+  return FALSE;
 }
 
 #if MENU_TOGGLE_ON_TOP

 the main part of this bug is about delete_event

now it's returning gboolean.

P.S. sorry for not responding for long.

caleb
joined: 2007-09-22
posted: 630
promoted: 134
bookmarked: 90
10subject: Promote 0 Bookmark 02009-06-26quote  

guest
the whole patch for evilvte:

Thank you!

I have tested and applied it to the evilvte trunk. :-)

guest
11subject: Promote 0 Bookmark 02009-06-26quote  

thank you.

btw, evilvte is missing one critical thing: search in buffer. I've tried to find something in libvte reference, but all I've found is

for visible buffer part :( If you could tell me how do I get the buffer data or raw pointer to text I could implement this and post a patch.

search dialog is used not often, but I've got pretty used to it.

caleb
joined: 2007-09-22
posted: 630
promoted: 134
bookmarked: 90
12subject: Promote 0 Bookmark 02009-06-26quote  
guest
btw, evilvte is missing one critical thing: search in buffer. I've tried to find something in libvte reference, but all I've found is

for visible buffer part :( If you could tell me how do I get the buffer data or raw pointer to text I could implement this and post a patch.

As far as I know, VTE does not provide this feature.

And, no VTE based terminal emulators has this feature yet.

guest
13subject: Promote 0 Bookmark 02009-06-26quote  
:(:(:( /me went hacking libvte

enComputerevilvte
adm Find login register
views:28590